Game help

[altunozara]

I have started learnign c++ and i know i do have a logn way to go. But i decided to make lots of mini tools in the process just to help me learn. In the future i will make them all fun in some way. i have been trying to make a program that asks for your name and you input your name and it sais it back

#include <iostream>
using namespace std;
int main()
{
int name;

cout<<"Hello! What is your name?: ";
cin>> name;
cin.ignore();
cout<<"Hello "<< name <<"\n";
cin.get();
}


that is what i have so far but it doesnt work please tell me what i did wrong...

[JaSo PsP]

'int' is short for 'integer' meaning number, name isnt a number, change:

int name;

to:

char name[20];

(assuming the maximum name length is 20 characters).

I just tested it, that was your only problem, it should work now.

[Glynnder]

what about setting name to be a string?

[yaustar]

Originally Posted by altunozara

I have started learnign c++ and i know i do have a logn way to go. But i decided to make lots of mini tools in the process just to help me learn. In the future i will make them all fun in some way. i have been trying to make a program that asks for your name and you input your name and it sais it back

#include <iostream>
using namespace std;
int main()
{
int name;

cout<<"Hello! What is your name?: ";
cin>> name;
cin.ignore();
cout<<"Hello "<< name <<"\n";
cin.get();
}


that is what i have so far but it doesnt work please tell me what i did wrong...

That is because it is expecting an integer and not a string.
Read: http://www.nicollet.net/meta/tut.cpp
-= Double Post =-
Do not follow Jaso_psp's advice, he is giving you C advice rather then C++.

#include <iostream>
#include <string>

using namespace std;

int main()
{
	string name;
	cout <<"Hello! What is your name?: ";
	cin >> name;
	cout << "Hello "<< name << endl;
	cin.get(); 
}

[JaSo PsP]

oh crap, i gave him C advice for another thread aswell :S. Then again, whats so bad about my method, it outputs the same result.

[Archaemic]

It's a C string. If you're in C++, you should use C++ strings.

[pspballer07]

I think its better to use char* or char[] so that way u don't have to include iostream (it adds a lot of unneeded stuff to the eboot or executable)

[Archaemic]

Um, strings are in the string header, not iostream. iostream you don't need anyway unless you're doing file IO.

[pspballer07]

C version:
char *name = (char*)malloc(sizeof(char )*20);

C++ version:
char *name = new char[20];

or just do it with arrays like Jaso said
char name[20];

[yaustar]

It only links what is needed and quite frankly, who cares if there is another 2k on the ELF size? If you are going to use C++ then make full use of the C++ standard library. That includes type safety and self sufficient objects (i.e. strings, vectors, lists). With C++ strings, you don't have to worry about NULL terminated strings or accidentally overrunning the char array. It is all handled internally which leaves the programmer to concentrate on the functionality of the program instead.

Use char * is just asking for trouble.

[pspballer07]

Originally Posted by Archaemic

Um, strings are in the string header, not iostream. iostream you don't need anyway unless you're doing file IO.

i still don't like using them

[yaustar]

Originally Posted by pspballer07

C version:
char *name = (char*)malloc(sizeof(char )*20);

C++ version:
char *name = new char[20];

or just do it with arrays like Jaso said
char name[20];

That is the worse advice I have seen. Apart from the last one, the first two leads to memory fragmentation and memory leaks if not handled correctly or used repeatedly.

The C++ version is:

std::string name = "I really don't give a crap what size this string is";
name = "nor do I have to bother dealing resizing or having to use the dangerous C string library to do this";

[MiG]

Originally Posted by pspballer07

i still don't like using them

Cry me a river.. C++ Strings are just better, listen to yaustar.

[Archaemic]

yaustar: If you don't strip the executable properly (which the PSP toolchain does anyway, so it doesn't matter), iostream can add upwards of 230kB to a file, IIRC.

Wow, I'm wrong. I just tested it in Cygwin with a basically empty file (not using the PSP toolchain, but whatever), and the file is over 400kB before stripping. It's 230kB AFTER stripping. That's a big deal compared to what you can usually pack into an executable.

[yaustar]

This code is quite easily done by a beginner following your advice:

char *name1 = (char*)malloc(sizeof(char )*20);
// Put a string in name1
char *name2 = (char*)malloc(sizeof(char )*20);
// Put a string in name2

// Programmer attempts to make name2 string equal to name1
name1 = name2;
// Whoops, memory leak through pointer reassignment

[yaustar]

Originally Posted by Archaemic

yaustar: If you don't strip the executable properly (which the PSP toolchain does anyway, so it doesn't matter), iostream can add upwards of 230kB to a file, IIRC.

Wow, I'm wrong. I just tested it in Cygwin with a basically empty file (not using the PSP toolchain, but whatever), and the file is over 400kB before stripping. It's 230kB AFTER stripping. That's a big deal.

It is barely 6k on a PC. I am not with my PSP toolchain at the moment so I try it later but I doubt it be THAT large.

[pspballer07]

Originally Posted by yaustar

That is the worse advice I have seen. Apart from the last one, the first two leads to memory fragmentation and memory leaks if not handled correctly or used repeatedly.

The C++ version is:

std::string name = "I really don't give a crap what size this string is";
name = "nor do I have to bother dealing resizing or having to use the dangerous C string library to do this";

that is why I handle it and free() it or delete it. using char* "in my opinion" is better
-= Double Post =-

Originally Posted by yaustar

This code is quite easily done by a beginner following your advice:

char *name1 = (char*)malloc(sizeof(char )*20);
// Put a string in name1
char *name2 = (char*)malloc(sizeof(char )*20);
// Put a string in name2

// Programmer attempts to make name2 string equal to name1
name1 = name2;
// Whoops, memory leak through pointer reassignment

well if the beginner read up on it instead of jumping in then they would realize that u simply use strcpy()

[yaustar]

Originally Posted by pspballer07

that is why I handle it and free() it or delete it. using char* "in my opinion" is better
-= Double Post =-

well if u read up on it then u would realize that u simply use strcpy()

Convince me.

Even strcpy is dangerous:

char name1[10] = "";
char name2[30] = "12345678901234567890123465789";
strcpy( name1, name2 );
// Whoops CRASH!

[Archaemic]

Originally Posted by yaustar

It is barely 6k on a PC. I am not with my PSP toolchain at the moment so I try it later but I doubt it be THAT large.

I'd like to know what compiler/strip utility YOU'RE using. I just repeated the test with MinGW and got the same results.

E] Yes, strcpy is very dangerous. It can lead to buffer overflows so quickly if you don't properly null-terminate a string, it's ridiculous. Even strncpy is dangerous if you don't know what you're doing.

[Darkhunter]

This is my code.

Spoiler for my code:

#include <cstdlib>
#include <iostream>

 using namespace std;

 int main(int argc,  char *argv[])
{
           string yourName;

           cout << "Please type your name and pres enter: ";
           cin >> yourName;

          cout << endl << "Hello, " << yourName << endl << endl;

          cout << " Press c and then enter to continue...";

          char justWait;
          cin >> justWait;

          return (EXIT_SUCCESS);
}

[Archaemic]

Replace cstdlib with string

[Darkhunter]

Originally Posted by Archaemic

Replace cstdlib with string

It still works

[pspballer07]

Originally Posted by yaustar

Convince me.

Even strcpy is dangerous:

char name1[10] = "";
char name2[30] = "12345678901234567890123465789";
strcpy( name1, name2 );
// Whoops CRASH!

like i said, if u read on it, u'll know not to do that

[yaustar]

Using MSVS 8 2005

#include <iostream>

using namespace std;

int main()
{
	cout << "Hello World" << endl;
}

On a release build for size comes out at 8k.

[pspballer07]

well, this is for altunozara if they want to use char* or char[]
http://www.cplusplus.com/reference/clibrary/cstring/

[yaustar]

Originally Posted by pspballer07

like i said, if u read on it, u'll know not to do that

Or, you can avoid the issue completely and use C++ strings and reduce the number of possible bugs in your program regarding strings to a VERY small number.
-= Double Post =-

Originally Posted by pspballer07

well, this is for altunozara if they want to use char* or char[]
http://www.cplusplus.com/reference/clibrary/cstring/

altunozara: Ignore this advice, if you are using C++, there is no reason at all to use C style strings.

[pspballer07]

Originally Posted by yaustar

altunozara: Ignore this advice, if you are using C++, there is no reason at all to use C style strings.

WOW lol "ignore this advice," lol nobody's right but u

altunozara, do what u want

[yaustar]

No, everybody's right but you pspballer07.

[JaSo PsP]

all he wanted to do is use chars or strings instead of integers, we showed him many ways of making his program WORK. You guys just went off on one lol.

[yaustar]

The way I see it is that using C strings in a C++ program where C++ strings can be used is like drinking soup with a fork when you can easily use a spoon.