First c experience (fixed)

[petervaz]

This is the first program I made in C.

It is a little game and I´m posting to get tips from the veterans. It still has a lot to be done but I´m posting now that the structure is done so if there any change to be made, better do it earlier.
My previous experience was mostly on pascal and I made this based only on the psp-programming tutoriais. I have some php experience that helped too.

The objective of the game would be the only color remaining, it is kinda intuitive so I won´t explain here.

I put some comments on the code so the veterans will grasp it easier. I think it´s is easy enough for others begginers to study also. I´m accepting any hint or constructive criticism.

What I´m planning next (in order):
A.I. for the computer (play alone is boring)
PNG´s instead of drawing.
Some sound to make marrier.
Learn how use fonts
Multiplayer adhoc (I´m dreaming here but since I will need for my next homebrew ideas better work to learn it)


(Sorry if some sentences didn´t make sense, english isn´t my native language)

[eldiablov]

erm. what?

[Adiuvo]

Exactly what is it and why do you need us to compile it?

[eldiablov]

where are you getting the idea that he needs something compiling ? I see no attachment. At all ...

[Adiuvo]

Originally Posted by eldiablov

where are you getting the idea that he needs something compiling ? I see no attachment. At all ...

This was it.

[_dysfunctional]

This is whole "I'm to lazy to set up my compiler, so will you plzzz compile it for me????" needs to stop. QJ should ban as it truly is a request.

[eldiablov]

Adiuvo, thats weird i got a qj attachment error message

_dysfunctional is totally right. it causes mess in the development forum and is an annoyance.

Im sorry but if you cant setup your own compiler then with regret. You're on your own. sorry.

[petervaz]

Err, sorry about that.
I slipped the enter key when starting to make the post and did this mess.
Not the best first impression, i suppose.

[eldiablov]

petervaz, go to psp-programming.com and click on tutorials

They will give you what you need to get started

[myschoo]

attachment doesnt work btw.

Invalid Attachment specified. If you followed a valid link, please notify the administrator

[_dysfunctional]

Just a few pet peeves. You use a lot of global variables rather than passing variables as an argument, and you use a lot of underscores in your variable names.

[JaSo PsP]

Originally Posted by _dysfunctional

Just a few pet peeves. You use a lot of global variables rather than passing variables as an argument, and you use a lot of underscores in your variable names.

You use an underscore in you NAME Whats wrong with using underscores?

[michaelp]

Originally Posted by _dysfunctional

This is whole "I'm to lazy to set up my compiler, so will you plzzz compile it for me????" needs to stop. QJ should ban as it truly is a request.

he never asked anything to be compiled, he asked if some more experienced coders could look at his code and give some helpful hints or constructive criticism

edit: did he ask it to be compiled before he edited it?

[_dysfunctional]

int this_is_the_variable_for_my_x_axis_and_btw_underscores_suck;
int thisIsTheVariableForMyXAxisAndBtwUnderscoresSuck;

Much easier to type.

[petervaz]

Originally Posted by michaelp

he never asked anything to be compiled, he asked if some more experienced coders could look at his code and give some helpful hints or constructive criticism

edit: did he ask it to be compiled before he edited it?

I messed up on the first post and posted only the attachment, by the time I corrected there half dozen posts already (quick fingers around here!)

Originally Posted by _dysfunctional

Just a few pet peeves. You use a lot of global variables rather than passing variables as an argument, and you use a lot of underscores in your variable names.

I guess the underscore thing is more a question personal preference, well, I actualy never though about it, just did.

About the globals, well, nowadays I´m making my life programming on cobol so I still have to learn how to get the best out of functions and arguments. The way I made looks me more readable and easier to track. Why is it a bad habit?

No arguing here, just looking for a better understanding.

btw, the colors variables were all on redraw() function, i moved them out so I could use on others functions.

Thanks for your anwser.

[yaustar]

I just shout off a list as I see them:

• Macro function instead of inlined function. By doing that you lose type safety and the resulting compiled code may be slower. Also harder to debug.
• Macro constants where enums should be used.
• Non constant globals.
• Inconsistent naming convention for functions and variable names.
• Use of magic numbers instead of constants.

Globals are bad because any function can access them so it breaks encapsulation and makes it harder to debug as you may not remember which functions change the value of the same global.

[petervaz]

Originally Posted by yaustar

I just shout off a list as I see them:

• Macro function instead of inlined function. By doing that you lose type safety and the resulting compiled code may be slower. Also harder to debug.
• Macro constants where enums should be used.
• Non constant globals.
• Inconsistent naming convention for functions and variable names.
• Use of magic numbers instead of constants.

Globals are bad because any function can access them so it breaks encapsulation and makes it harder to debug as you may not remember which functions change the value of the same global.

Thanks for your feedback. Solid advice in there.
Hmmm... Now I should look up for some terms

[_dysfunctional]

Well, what yaustar is saying...

You do:

#define addOne(x) x+1

instead of,

inline int addOne(int x)
{
    return x+1;
}

You do:

#define PLAYER_ONE 1
#define PLAYER_TWO 2
#define PLAYER_THREE 3
#define PLAYER_FOUR 4

instead of,

enum PlayerList
{
     PLAYER_ONE = 1,
     PLAYER_TWO = 2,
     PLAYER_THREE = 3,
     PLAYER_FOUR = 4
};

etc, etc.


The rest are simple, so I won't right them up. :P