RPG Demo V6

[Xteaph-N]

Everything has been completely rewritten. The Overworld uses tile based maps. Also the battle system has been rewritten to use table based systems as well.

Can another dev peer review my code. I'm not happy with it.

http://www.sendspace.com/file/0ly5ha

[Release] http://xteaphn.blogspot.com/2009/07/rpg-demo-v6.html

[Miclowgunman]

not too shabby! throw an extra tile out there for land to show off the tile system, like mountains or something. The battle system needs some limiters though. play with some input delay timers to get a good feel so it doesnt feel like the menu system is fritzing or moving to slow when you press a button. Good progress in a good direction. Keep it up!

[_df_]

Originally Posted by Xteaph-N

Can another dev peer review my code. I'm not happy with it.

well you repeat code everywhere..

stuff like

if Counter[2].num == 6 then....

needs to be replaced with

if Counter[2].num >= 6 and Counter[2].num <= 26 and Counter[2].num % 4 == 0 then
    TileX = TileX - 4;
end

Your using this pattern/smell of code all over the place and you could effectively cut half the lines of code out with an amalgamated if statement.

also you have lots of global variables. basically every variable in your game is global (bad). You should (imo) place all game state vars inside a table which is global (and the only global variable) so its super easy to serialse for save/load and make every other variable local.

Lua's power comes from tables and that its functional, if you want to step up in using lua's power, start using anonymous functions or passing functions around. The state system could easily be replaced with functions as state rather than if statements.

eg:

if Player[setPlayer].turn == "Option" then

could be

Player[setPlayer].turn()

and instead of changing state with

Player[setPlayer].turn = "Attack_Choose";

have

Player[setPlayer].turn = state_Attack_Choose

where state_Attack_Choose is a function. Start reusing code more.

once you grok anonymous functions and passing functions around, things really start to open up.

[Xteaph-N]

@_df_

Thanks! I was upset that I was uselessly iterating my code, so this is going to help me a lot. Especially the thing about anonymous functions and function passing. I have a feeling that will help the most! But I'm not entirely sure how I would use them in my code per se.

@Miclowgunman

Thanks for the words of encouragement.

[Digitalboy]

good work xteaph-n.you made some good progress from the first versions.i'l keep an eye on it.(RPG RULZ!)