Printable View
You know, you will get more help if you're code is actually readable. (Indenting, not one-word-per-line)
Anyway, what are you trying to accomplish with that "until"? "until" is used like this:
repeat block until exp
It's basically a reverse "while" loop
Your code is horrible. I took out all the comments and made things on the same line here. A couple of things which I'm not sure where they are, but these are the problems:Code:origpic = Image.load(browserbg.png)
resize = ""
pictouse = ""
function sizecheck()
if origpic:height() > 240 or origpic:width() > 230 then
resizecheck()
else
pictouse = screen:blit(244, 37, origpic)
end
end
rvx = 0
rvy = 0
function resizecheck()
if origpic:height() > origpic:width() then
resize = y
elseif origpic:width() > origpic:height() then
resize = x
elseif origpic:height() == origpic:width()
then
resize = x
end
resizevalues()
end
function resizevalues()
if resize == x then
rvx = origpic:width() / 2
rvy = origpic:height() / 2
until
rvx < 240
elseif
resize == y
then
rvx = origpic:width() / 2
rvy = origpic:height() / 2
until
rvy < 230
end
end
end
resizepicture(rvx, rvy, origpic)
end
function resizepicture(newx, newy, theimage)
newpicture = Image.createEmpty(newx, newy)
for thex = 1, newx do
for they = 1, newy do
newpicture:blit(thex, they , theimage, math.floor(thex * (theimage:width() / newx)), math.floor(they * (theImage:height() / newy)), 1, 1)
end
end
return pictouse = newpicture
end
function blitpic()
pictouse
end
while true do
blitpic()
1. One of your functions is "pictouse". That means absolutely nothing. Putting a random variable in a functions is... WTF?
2.???? You are trying to assign something to "pictouse" using screen:blit? Does screen:blit even return anything?Code:pictouse = screen:blit(244, 37, origpic)
3. As Nielkie said, why is there a random until in the middle of nowhere?
4.I'm pretty sure that is not how return statements work...Code:return pictuose = newpicture
There are an unbelievable amount of problems with your code.
ok maybe if i explain what i was wanting to do it is hard to know what i am doing wrong when i dont have much time and have to work on it in little bits so as i said earlier it was taking too long so i came to ask for some help
the code is meant to take an image either predefined or defined from a file browser
then when it has loaded the file see if it needs resizeing or not
if it doesnt skip the whole resize process to save time
if it does then do the resize function (which is very messed up i know) (i just explained why above)
then it checks the x and y and sees which is larger
then it makes both x and y untill the larger is smaller than the defined value
then it resizes using the defined values and blits the image to the screen
well thats what ti is supposed to do but it doesnt
so i am asking for some help pleas for example some revised code or a propper explanation of how to fix the problems that you have apparently found
thanks
This is where you get help with your code. Not where others code for you. Post the code you have, and we'll help you fix it.Zitat:
Zitat von FaT3oYCG
He did post his code. Check a couple posts back. My last post takes out all of the comments and organizes it a bit.
First of all, you pretty much need to take out that until. For sure, unless you know how to use this:
http://lua-users.org/wiki/ControlStructureTutorialCode:repeat
block of code
until expression
You did not end your main loop, "while true do". Put an end at the end of it.
Try making the variable names more descriptive so you don't need so many comments. Instead of rvy and rvx, make them what they mean.
Indent!!!! So you know where to put "end"s.
Untested, but this is basically what you're code is trying to do in a condensed forum.
Code:function load_img_scaled(image,width,height)
local retimg;
local img = Image.load(image)
local aspect = img:width / img:height
local function scaleimg(theImage,newX,newY)
resizedImage = Image.createEmpty(newX, newY)
for x = 1, newX do
for y = 1, newY do
resizedImage:blit(x,y , theImage, math.floor(x*(theImage:width()/newX)), math.floor(y*(theImage:height()/newY)),1,1)
end
end
return resizedImage
end
if img:width > width and img:height > height then
if img:width > img:height then
local heightA = width / aspect
retimg = scaleimg(img,width, heightA)
else
local widthA = height * aspect
retimg = scaleimg(img,widthA, height)
end
elseif img:width > width then
local heightA = width / aspect
retimg = scaleimg(img,width, heightA)
elseif img:height > height then
local widthA = height * aspect
retimg = scaleimg(img,widthA, height)
else
retimg = img
end
return retimg
end
usage: load_img_scaled("path/to/file.png",maxwidth,maxhei ght)
e.g:
resized_image = load_img_scaled("pic_that _is_bigger_than_480x272.p ng",480,272)
You put a semi-colon at the end of your second line.
Code:function load_img_scaled(image,width,height)
local retimg;
thanks a load i modified it slightly to make it work but thanks
here is the finished and working code
thank you so much neilkieCode:function load_img_scaled(image,width,height)
local retimg;
local img = Image.load(image)
local aspect = img:width() / img:height()
local function scaleimg(theImage,newX,newY)
resizedImage = Image.createEmpty(newX, newY)
for x = 1, newX do
for y = 1, newY do
resizedImage:blit(x,y , theImage, math.floor(x*(theImage:width()/newX)), math.floor(y*(theImage:height()/newY)),1,1)
end
end
return resizedImage
end
if img:width() > width and img:height() > height then
if img:width() > img:height() then
local heightA = width / aspect
retimg = scaleimg(img,width, heightA)
else
local widthA = height * aspect
retimg = scaleimg(img,widthA, height)
end
elseif img:width() > width then
local heightA = width / aspect
retimg = scaleimg(img,width, heightA)
elseif img:height() > height then
local widthA = height * aspect
retimg = scaleimg(img,widthA, height)
else
retimg = img
end
return retimg
end
resized_image = load_img_scaled("image.png",230,136)
while true do
screen:blit(244, 37, resized_image)
screen.flip()
screen.waitVblankStart()
end
you are allowed to do that so it won't mess anything upZitat:
Zitat von michaelp
I need a better way to select a random line from a file.
I'm trying to write a name generator for the PSP. I have a file with a list of names in it, one per line.
My code works perfectly for small files (under about 1000 lines), but for larger ones (like 300Kb), it gives me the error "No space left on device". Seems there isn't enough memory to load the entire file into memory.
Any suggestions on a more memory efficient way to do this? My existing code is below. It opens the file into a table and returns 5 randomly selected names.
Code:
function getname()
firstnamefile = "names-first.txt"
local count = 0
local lines = {}
for line in io.lines(firstnamefile) do
table.insert(lines, line)
end
-- Figure out how many there are
count = table.maxn(lines)
-- Select 5 random names
first1 = lines[math.random(1,count)]
first2 = lines[math.random(1,count)]
first3 = lines[math.random(1,count)]
first4 = lines[math.random(1,count)]
first5 = lines[math.random(1,count)]
return first1, first2, first3, first4, first5
end
Instead of reading the entire file into memory, you can use file:seek() to change the current position in the file, then read from that point:
http://pgl.yoyo.org/luai/i/file%3Aseek
Is there a way to seek by line instead of by byte?
Or would I just have to seek to a random location and read in two lines (one possibly partial line, one full line)?
i've been reading the collision tutorial on evilmana.com but dont understand any of it. what i'm trying to do is in a horizontal scrolling shooter i want the enemy to collide with the bullet, be replaced with an explosion animation, the explosion disappears and the enemy goes to 500(x) and a random position between 20 and 232(y). anyone know how to do this?
I don't think so, but you could do this:Zitat:
Zitat von nobodyimportant
Code:local ranline = math.random(1,io.lines("wordlist.txt"))
local ranword;
local count = 0
for lines in io.lines("wordlist.txt") do
count = count + 1
if count == ranline then
ranword = line
break --Not sure, can you break out of a for loop? I've never tried.
end
end
Thanks Nielkie. math.random doesn't like me putting io.lines in its parameters...says it was expecting a number but got a function.
But it did get me thinking.
My new function looks like this. It works, even on my 37000 line file. Wish there was a more efficient way, but it'll do for now:
The full script actually saves the number of lines in the file, so it doesn't have to repeat that step each time. It takes about 5 seconds the first time I run it, and about 3-4 for subsequent runs.Code:function getname()
filename = "names-first.txt"
-- Count lines in the file
local namelines = 0
for line in io.lines(lastnamefile) do
namelines = namelines + 1
end
-- Select 5 random lines
local name1num = math.random(1,namelines)
local name2num = math.random(1,namelines)
local name3num = math.random(1,namelines)
local name4num = math.random(1,namelines)
local name5num = math.random(1,namelines)
local name1found, name2found, name3found, name4found, name5found = false,false,false,false,false
local curline = 0
-- Go through the entire file,
-- selecting the lines as we encounter them.
-- When all the needed lines are found, exit
for line in io.lines(lastnamefile) do
curline = curline + 1
if curline == name1num then
name1 = line
name1found = true
end
if curline == name2num then
name2 = line
name2found = true
end
if curline == name3num then
name3 = line
name3found = true
end
if curline == name4num then
name4 = line
name4found = true
end
if curline == name5num then
name5 = line
name5found = true
end
if name1found and name2found and name3found and name4found and name5found then
break
end
end
making a slight change to the way nielkie set out the code would make i workZitat:
Zitat von Nielkie
by changing this code to
as you cannot use a function as a paramete or inside another function as the error you got explainedCode:endline = io.lines("wordlist.txt")
local ranline = math.random(1, endline)
local ranword;
local count = 0
for lines in io.lines("wordlist.txt") do
count = count + 1
if count = ranline then
ranword = line
break --Not sure, can you break out of a for loop? I've never tried.
end
end
try that and tell me what happens, there might be another error with nielkie's code near the end as also i dont know weather you can break a for loop.
anyway repot back and im sure either myself or nielkie will be able to help, unless someone else wants a pop at it
thanks
Why not just use something like this:
This works, and since you are only reading from the file 10 times, it'll be much faster than using io.lines to read through the file until you find five matches, especially if it's a file with 37000 linesCode:function getname()
filename = "names.txt"
file = io.open(filename)
filesize = file:seek("end") -- get the size of the file
names = {}
for i = 1, 5 do
local pos = math.random(filesize - maxnamesize - 1)
if pos < 1 then pos = 1 end
file:seek("set", pos )
file:read()
names[i] = file:read()
end
file:close()
return names
end
Just a quick question, could anyone give me an example of the usage of Font:getTextSize(string) ? I can't seem to get it working.
(using:
) (from here)Code:width = myfont:getTextSize(text)["width"]
EDIT: I see in the luaplayer 0.20 release notes:
- Font:getTextSize fixed.
Is it broken in 0.16?
If yes, is there any work-around?
why not just use the .20 version?
.16 is better than .20 IMO.
0.16 is much faster.Zitat:
Zitat von emericaska8r
oh yea true... maybe you could use the updated part in .20 and recompile that in the .16 version? don't know how all that stuff works so i couldn't tell you
hi guys , i ve got problem with neo motion kit and lua ...there isn't any compatibility!how i can map psp button? last question:I can ever use motion kit with lua? help please!
yes if someone adds the commands into luaplayer
but at the moment they are not included
you will probably have to make a custom lua player to use the motion kit by programming the commands
It would just be great if someone took the time on their hands to modify Lua Player to be able to connect with the Motion Kit.
Shouldn't the guys at LuaPlayer.org already have done it? it's over a year since Lua Player 0.20 was released..
Absolutely right. It has to do with the Image.createEmpty(width, height) extended alpha abilities, and i think it started in Lua Player 0.17, if i remember it right.Zitat:
Zitat von Nielkie
I would like to have some kind of switch between the two, like:
I think that will solve the problem, but maybe i'm wrong.Code:Image.createEmpty(width, height, fullapha boolean)
i would do it if i knew the commands or had the motion kit aslong as my compiler worked but at the moment it doesnt
if i get my compiler to work i will ask someone for the commands and do it for you
Well, when/if the SIO lib is fixed in the next luaplayer, it should be possible to do it directly in luaplayer.Zitat:
Zitat von FaT3oYCG
Something like this?
Code:System.sioInit(510416)
--wait awhile because it takes a few seconds in initialize...
Xaccel = 0
Yaccel = 0
for i=1,10 do
System.sioWrite("1") --string.char(tonumber("31",16))
Xaccel = Xaccel + tonumber(System.sioRead()) --I'm not sure if this will work...
System.sioWrite("2")
Yaccel = Yaccel + tonumber(System.sioRead())
end
Xaccel = Xaccel / 10
Yaccel = Yaccel / 10
Also, Googleing found this, though I'm not sure it is made for the motion kit.
If so, that would be great!Zitat:
Zitat von Nielkie
Zitat:
If so, that would be great!
yeah...
hey everybody got a question about coding for your player to pick up the items (i can do the code up to a point), but my question do i need to have another image with my character with say a gun in his hands to blit and replace the old image of the character without the gun? if so is there a snippet that i could look at to show me how to do that. thnx in advance ofr any help.
Zitat:
Zitat von %chrono trigger%
Code:player = {}
player.x = 0
player.y = 0
player.weapon = "gun"
player.img = {
["gun"] = Image.load("player_gun.png"),
["none"] = Image.load("player.png"),
["sword"] = Image.load("player_sword.png")
}
screen:blit(player.x,player.y,player.img[player.weapon])
thnxs that really helps :)
-----edit---------
ok i implemented that, but my old image isnt being replaced by the new one its just displaying both is there a certain function that would replace it im sort of confused. I think its because im using a if check collision function to deteermine if the image should be blitted which probaly isnt effective ill post that part of the code in a bit if need be
-= Double Post =-
srry for the double post mods, but i found the problem well sort of lol
ok so i solved my first problem by changing that code to:Code:if collision(Pic,Player) then
screen:blit(Player.x,Player.y,Player.img[Player.weapon])
screen.flip()
screen.waitVblankStart(30)
screen:clear()
end
which works, but my other image is still there, so i have my second image blitted on top of my first image which not only lags my game severly, but makes it look stupid. So basically i need to know how i can i guess replace and image.Code:if Player.x >= Pic[1].x then
screen:blit(Player.x,Player.y,Player.img[Player.weapon])
screen.flip()
screen.waitVblankStart(30)
screen:clear()
end
thnx in advance for the help
Why do you have a random waitVBlankstart there? Why are you fliping and clearing the screen?
Yeah, that makes no sense.Zitat:
I think its because im using a if check collision function to deteermine if the image should be blitted
You can't just 'replace' an image, I suggest you restructure your code.
Something like this:
Code:player = {}
player.x = 0
player.y = 0
player.weapon = "gun"
player.img = {
["gun"] = Image.load("player_gun.png"), --Image of the player with a gun
["none"] = Image.load("player.png"), --Image of the player widthout any weapon
["sword"] = Image.load("player_sword.png") --Image of the player with a sword
}
while true do
pad = Controls.read()
screen.clear()
screen:blit(player.x,player.y,player.img[player.weapon]) --Blits the player
if player picks up gun then
player.weapon = "gun"
end
if pad:left then
player.x = player.x - 1
end
if pad:right then
player.x = player.x + 1
end
--etc..
screen.waitVblankStart()
screen.flip()
end
ill look throught that thnx, and also about the random waitVBlankstart and fliping and clearing the screen its because i had it from when i changed my code and didnt take it out thnx for finding that since i have alot more code than this already done and i guess it got copy pasted with it or something, and i had the collision function was because this was part of my other game stickguy wich was a bust, but the coding was good. Again thnx ill take a look through your code and fix mine.
i was thinking of making an unreal tournament game for the psp coded in lua but i was just wondering if you think it would be better to do it in 3d and for it to take forever of to do it in 2d not be as good but take half the time just want to know what you think thanks
- if i was doing it in 3d i would also have to take some time to learn 3d too
- if it was in 2d i would probably have an alpha done in 3 weeks thanks
Do it in 3D. It would be sooo much cooler.
anyone know where i can find some tutorials or simply somewhere that tells me what each of the 3d lua functions do
i have found the functions but i would like to know their meanings anyone know where i can find that out
thanks
- otherwise im doining it in 2d soz
Someone is already working on a FPS engine in LUA, and it's in 3D. Unfortunately I don't remember who it was since I saw his video of the engine on Youtube. But I'm sure he would be of help.
To answer your question, you have to give more info on your LUA experience. And the way someone asks the questions can already tell a lot about that person's experience. So we already have a start there :)
You don't just "learn" 3D in the programming sense just like you don't "learn" games. The biggest leap in adjusting from 2D to 3D is in the physics. You might be able to do a simple Doom-type FPS but something in Unreal Tournament style has more complex physics and control.
We cannot help explain the functions to you unless you tell us where you found them, right? ;)Zitat:
i have found the functions but i would like to know their meanings anyone know where i can find that out
Can someone create a simple 3D FPS tutorial? Thanks!
No. That would be ridiculous.