C/C++ Programming Help Thread

[Archaemic]

stdio rather defines it, I'd say.

[PSPJunkie_]

stdio rather defines it, I'd say.

*Smacks head against a wall*

[youresam]

*Smacks head against a wall*

*helps*

[Archaemic]

...I'm missing something.

Did I say something stupid without realizing it again?
Forgive me, I'm rather tired right now.
Anyway, I just meant that stdio defines it, but doesn't use it.

[hallo007]

since i added the mouse part , it's just crashing

int main(SceSize args, void *argp)
{
    string desktopFiles[12][24];          //Storage for floople lloopst loopn desktop dlooprectory
    int z = 0;                            //storage for copying strings
    int x = 10;                            //storage for x coordinate
    int y = 10;                            //storage for y coordinate
    int mouseX = 10;
    int mouseY = 10;
    char imageBuffer[20];                 //buffer for image loading
    char *fileListBuffer;                 //buffer for file names
    
    SceCtrlData pad;
    sceCtrlSetSamplingCycle(0);
    sceCtrlSetSamplingMode(PSP_CTRL_MODE_ANALOG);
    
    
    Image *iconExample = loadImage("data/desktop/icon.PNG");//the icon
    Image *iconFolder  = loadImage("data/desktop/folder.PNG");
    Image *mouse       = loadImage("data/desktop/mouse.PNG");
    string fileBuffer[222];                               //for the filelist
    
    //init the garphics
    initGraphics();
    pspDebugScreenInit();
    pspDebugScreenClear();
    
    //Load screenshot module
    LoadStartModule("data/screenshot.prx");
    
    //loopmages load
    /*for(int loop = 0; loop < sizeof(desktopImages); loop++)
    {
             snprintf(imageBuffer ,sizeof(imageBuffer) - 1,  "%i.PNG" ,loop);
             desktopImages[loop] = loadImage(imageBuffer);
             }*/
             
    desktopBack = loadImage("data/desktop/wallpaper.PNG");
    /*if(desktopBack < 0) printf("failed to load image\n");
    else  printf("Image loaded\n");*/
    getFileList("ms0:/");  
    while(1)
    {
              
            //printf("file paths stored\n");

            //printf("Stored to new variabel\n");
            blitImage(0,0,desktopBack);
            for(int loop = 0; loop < sizeof(fileList); loop++ )
            {
                  char buffer[10];
                  if(y!=0) y += 10;
                  if(sizeof(fileList[loop]) > 10)
                  {
                                     strncpy(buffer , fileList[loop].c_str() , sizeof(buffer) - 3);
                                     strcat(buffer , "..");
                                     fileBuffer[loop] = buffer;
                                     }
                  else
                  {
                       fileBuffer[loop] = fileList[loop];
                       }
                 // if(isFile(fileList[loop]))
                  //{
                       blitImage(x , y ,iconExample);
                      // }
                 // else
                  //{
                       //blitImage(x , y ,iconFolder);
                       //}    
                  y += 40;    
                  printg(x , y , fileBuffer[loop].c_str() , white);
            
                  if(y > 249)
                  {
                      x += 108;
                      y = 10;
                      } 
                      }  
                  blitImage(mouseX , mouseY , mouse);
                  flipScreen();
                  while(1)
                  {
                          sceCtrlReadBufferPositive(&pad, 1);	 
                          
                          if (pad.Lx < 80) //left
                          {
                                     mouseX -= 10;
                                     if(mouseX<0) mouseX = 460;
                                     break;
                                     }
                          if (pad.Lx > 175) //right
                          {
                                     mouseX += 10; 
                                     if(mouseX > 480) mouseX = 0;
                                     break;
                                     }
	                      if (pad.Ly > 175) //down
	                      {
                                     mouseY -= 10;
                                     if(mouseY<0) mouseY = 255;
                                     break;
                                     }
	                      if (pad.Ly < 80) //up
	                      {
                                     mouseY += 10;
                                     if(mouseY > 272) mouseY = 0;
                                     break;
                                     }
                          if(pad.Buttons & PSP_CTRL_HOME)
                          {
                                         sceKernelExitGame();
                                         }
                    }
                   
    }//end while

   /* for(int loop = 0; loop < 12; loop++ )
         for(int looptwee = 0; looptwee < 24; looptwee++ )
         {
                 getImageToBuffer[loop][looptwee] = getImage(desktopFiles[loop][looptwee].c_str());                         
                 blitImage(x , y ,  getImageToBuffer[loop][looptwee]);
                 x += 20;
                 y += 20;
                 }*/
              
    flipScreen();
    
    sceKernelSleepThread();
    return 0;
}

yes , i know the code is ugly at the moment

[yaustar]

thats why you #define it after #include'ing it *omg*

Unless you know the exact order of files that the preprocessor goes through, that is a dangerous assumption to make. It be better (but still horrendous) to use printfSomeElse or:

#ifdef WINDOWS
#define printfDebugText printf
#else
#define printfDebugText pspDebugScreenPrintf
#endif

int main()
{
    //.....
    printfDebugText( "Hello World" );
}

That would be better and safer then #defining the name of a stdio function name.
-= Double Post =-

Hey Hallo007, my suggestion would be this

//DEFINES
char fileList[222][200]; //********change from string to char[],  200 is the max filename length

That would just be plain stupid. STL Strings are much safer then char strings by a mile. ¬¬

[youresam]

I believe the reason people define pspDebugScreenPrintf as printf is to make typing easier, so defining it to a word of about the same length is kinda pointless.
How about..

#define omgprintf pspDebugScreenPrintf

There, all better.

[hallo007]

Spoiler for main.cpp:

#include <stdlib.h>
#include <malloc.h>
#include <pspdisplay.h>
#include <psputils.h>
#include <png.h>
#include <pspgu.h>
#include <string>
#include <pspkernel.h>
#include <pspctrl.h>

#include "desktop.h"
#include "graphics/graphics.h"

#include "io/iO.h"
#include "variabels.h"

//DEFINES
#define blitImage blitAlphaImageToScreen
#define printg printTextScreen
#define printf pspDebugScreenPrintf

//MODULE INFO
PSP_MODULE_INFO("TEST" , 0x1000, 1, 1);
PSP_MAIN_THREAD_ATTR(0);
//100% c++ :P
using namespace std;

Image *desktopImages[11];
Image *desktopBack;




int LoadStartModule(char *path)
{
u32 loadResult;
u32 startResult;
int status;

loadResult = sceKernelLoadModule(path, 0, NULL);
if (loadResult & 0x80000000) return -1;

startResult = sceKernelStartModule(load Result, 0, NULL, &status, NULL);

if (loadResult != startResult) return -2;

return 0;
}
int isFile( string filename)
{
SceIoStat stats;
sceIoGetstat( filename.c_str(), &stats);//get the stats

if ( stats.st_mode & FIO_S_IFDIR) //directory?
return 0; //if directory
else
return 1; //if file
}
int main(SceSize args, void *argp)
{
int x = 10; //storage for x coordinate
int y = 0; //storage for y coordinate
int mouseX = 10; //storage for mouse coordinates on x-as
int mouseY = 10; //storage for mouse coordinates on y as
int imageError = 0; //bool for error on image loading
string fileBuffer[222]; //for the filelist

//Pad init
SceCtrlData pad;
sceCtrlSetSamplingCycle(0 );
sceCtrlSetSamplingMode(PS P_CTRL_MODE_ANALOG);

//init the garphics
initGraphics();
pspDebugScreenInit();
pspDebugScreenClear();

//Image loading
Image *iconExample = loadImage("data/desktop/icon.PNG");
if(iconExample == NULL) imageError = 1;
Image *iconFolder = loadImage("data/desktop/folder.PNG");
if(iconFolder == NULL) imageError = 1;
Image *mouse = loadImage("data/desktop/mouse.PNG");
if(mouse == NULL) imageError = 1;
desktopBack = loadImage("data/desktop/wallpaper.PNG");
if(desktopBack == NULL) imageError = 1;

if(imageError)//if some images failed to load
{
pspDebugScreenClear();
printf("error : failed to load an image:\n");
sceKernelSleepThread();
return 0;
}

//Load screenshot module
LoadStartModule("data/screenshot.prx");

//get al files stored to a string of a directory
getFileList("ms0:/");

while(1)
{
blitImage(0 , 0 , desktopBack);//wallpaper
for(unsigned int loop = 0; loop < sizeof(fileList); loop++ )
{
char buffer[10];
y += 10; //go away from the file name
if(sizeof(fileList[loop]) > 10)
{
strncpy(buffer , fileList[loop].c_str() , sizeof(buffer) - 3);
strcat(buffer , "..");
fileBuffer[loop] = buffer;
}
else
{
fileBuffer[loop] = fileList[loop];
}
if(isFile(fileList[loop]))
{
blitImage(x , y ,iconExample);
}
else
{
blitImage(x , y ,iconFolder);
}
y += 40;
printg(x , y , fileBuffer[loop].c_str() , white);

if(y > 249)
{
x += 108;
y = 10;
}
}//end for loop
printf("STEP 3 DONE , WAIT 5 SECONDS");
sceKernelDelayThread(5000 000);
pspDebugScreenClear();
blitImage(mouseX , mouseY , mouse);
flipScreen();
while(1)
{
sceCtrlReadBufferPositive (&pad, 1);

if (pad.Lx < 80) //left
{
mouseX -= 10;
if(mouseX<0) mouseX = 460;
break;
}
if (pad.Lx > 175) //right
{
mouseX += 10;
if(mouseX > 480) mouseX = 0;
break;
}
if (pad.Ly > 175) //down
{
mouseY -= 10;
if(mouseY<0) mouseY = 255;
break;
}
if (pad.Ly < 80) //up
{
mouseY += 10;
if(mouseY > 272) mouseY = 0;
break;
}
if(pad.Buttons & PSP_CTRL_HOME)
{
sceKernelExitGame();
}
}//end while

}//end while

sceKernelSleepThread();
return 0;
}

Spoiler for io.cpp:

void getFileList(string path)
{
SceUID bufferFile;
int z = 0;

bufferFile = sceIoDopen(path.c_str());
if(bufferFile > 0)
{
SceIoDirent dir;
memset(&dir, 0, sizeof(SceIoDirent));
while(sceIoDread(bufferFi le, &dir) > 0)
{
fileList[z] = dir.d_name;
z++;
if(z > 222 ) break;
}
sceIoDclose(bufferFile);
}
}

a bit rewritten and i still dindt saw a mistakes , there are no warnings either

aargh dammit , with copy/paste get every space lost:-(

[yaustar]

...I'm missing something.

Did I say something stupid without realizing it again?
Forgive me, I'm rather tired right now.
Anyway, I just meant that stdio defines it, but doesn't use it.

Stdio declares it as a function prototype, by using the #define printf etc, it is possible that the preprocessor has changed the name of the function prototype depending on the order of files that the preprocessor has gone through.

[Archaemic]

Eek. That is dangerous. I just changed all of my "printf"s to "say". Not because it's short, but because it makes sense.

However, this is just a temporary solution until my partner creates the bitmap font. SDL_ttf looks a little bit too difficult to work with for what I'm using it for. I'd be doing a lot of metric checking, which could get slow.

[hallo007]

anyone saw the error in my code yet?

[Archaemic]

Have you, oh, I don't know, tried running it in PSPLink so you can find out where it crashed? That's generally helpful information.

[yaustar]

I believe the reason people define pspDebugScreenPrintf as printf is to make typing easier, so defining it to a word of about the same length is kinda pointless.
How about..

#define omgprintf pspDebugScreenPrintf

There, all better.

That is what auto completion is for in text editors and IDEs.

From: http://www.psp-programming.com/forum...p?topic=2161.0

The thing is, most of the people who are reading these tutorials are extremely beginner (as in first time programming). The point of shortening to printf was to allow them to use other general C tutorials online on the PSP and achieve expected results.

[hallo007]

Have you, oh, I don't know, tried running it in PSPLink so you can find out where it crashed? That's generally helpful information.

i dont have a psp

[youresam]

Have you, oh, I don't know, tried running it in PSPLink so you can find out where it crashed? That's generally helpful information.

Or just set up an exception handler and use psp-addr2line? Would be much more helpful

[Archaemic]

That's also helpful if you're writing a kernel mode application, I guess. Although--

i dont have a psp

Um...then how are you testing this?

[hallo007]

friends / beta testers

i found out it crashes here:

    while(1)
    {            
            blitImage(0 , 0 , desktopBack);//wallpaper
            for(unsigned int loop = 0; loop < sizeof(fileList); loop++ )
            {
                  char buffer[10];
                  y += 10; //go away from the file name
                  if(sizeof(fileList[loop]) > 10)
                  {
                                     strncpy(buffer , fileList[loop].c_str() , sizeof(buffer) - 3);
                                     strcat(buffer , "..");
                                     fileBuffer[loop] = buffer;
                                     }
                  else
                  {
                       fileBuffer[loop] = fileList[loop];
                       }
                 if(isFile(fileList[loop]))
                 {
                       blitImage(x , y ,iconExample);
                       }
                 else
                 {
                       blitImage(x , y ,iconFolder);
                       }    
                  y += 40;    
                  printg(x , y , fileBuffer[loop].c_str() , white);
            
                  if(y > 249)
                  {
                      x += 108;
                      y = 10;
                      } 
                      }

anyone see something?

[PSPJunkie_]

Did you try any debugging methods?

[pspballer07]

friends / beta testers

i found out it crashes here:

    while(1)
    {            
            blitImage(0 , 0 , desktopBack);//wallpaper
            for(unsigned int loop = 0; loop < sizeof(fileList); loop++ )
            {
                  char buffer[10];
                  y += 10; //go away from the file name
                  if(sizeof(fileList[loop]) > 10)
                  {
                                     strncpy(buffer , fileList[loop].c_str() , sizeof(buffer) - 3);
                                     strcat(buffer , "..");
                                     fileBuffer[loop] = buffer;
                                     }
                  else
                  {
                       fileBuffer[loop] = fileList[loop];
                       }
                 if(isFile(fileList[loop]))
                 {
                       blitImage(x , y ,iconExample);
                       }
                 else
                 {
                       blitImage(x , y ,iconFolder);
                       }    
                  y += 40;    
                  printg(x , y , fileBuffer[loop].c_str() , white);
            
                  if(y > 249)
                  {
                      x += 108;
                      y = 10;
                      } 
                      }

anyone see something?

If it doesn't compile right it's because you are declaring the unsigned int loop in the for statement. In C, you have to declare it out of or right before the for statement like this:

unsigned int loop;
for(loop = 0; loop<whatever;loop++)
{
}

[Archaemic]

Take a look at the code for a moment and you'll see this: "fileBuffer[loop].c_str()". He's using STL strings, which means that this is C++, therefore it's valid. Also, he said it was crashing, which means it must be compiling.

E] Wait, where's buffer defined?
E2] Nevermind, I see it now.

[hallo007]

string fileBuffer[222]; ?

no i dindt tried the debugging methods because i havent got a psp and my friends havent got cygwin or the knowledge to use it

[PSPJunkie_]

...

Member that little lesson we gave you on using #define, #ifdef, and #ifndef to debug?

[hallo007]

o yeah , wait it is a few pages back

i thought you mean psplink;-)
-= Double Post =-
#define DEBUG

#ifdef DEBUG
...
#endif


but what is this gong to help?

[Archaemic]

                  char buffer[10];
                  y += 10; //go away from the file name
                  if(sizeof(fileList[loop]) > 10)
                  {
                                     strncpy(buffer , fileList[loop].c_str() , sizeof(buffer) - 3);
                                     strcat(buffer , "..");
                                     fileBuffer[loop] = buffer;
                                     }

This is terribly unsafe. If you're going to strcat it, at least make sure to memset buffer to 0 first, otherwise you'll have an instant buffer overflow right there.

[hallo007]

sizeof(buffer) - 3

i reserved two bytes for the ".."

[yaustar]

You are using C++ strings dammit. Use C++ string operations !!
http://www.cppreference.com/cppstring/append.html
-= Double Post =-

if(sizeof(fileList[loop]) > 10)

This does not work C++ strings are objects and hold extra data besides the actual char string.
http://www.cppreference.com/cppstring/length.html

[Archaemic]

sizeof(buffer) - 3

i reserved two bytes for the ".."

That's not where the overflow is coming from. The overflow is coming from the fact that the memory allocated is not necessarily all 0. It could be a (seemingly) random string of characters.

[PSPJunkie_]

o yeah , wait it is a few pages back

i thought you mean psplink;-)
-= Double Post =-
#define DEBUG

#ifdef DEBUG
...
#endif


but what is this gong to help?

Are you serious?

[hallo007]

yes I am

thnx yauster , i take a look

[Archaemic]

Why can no one spell yaustar? Honestly, it's not that hard to remember.

Anyway, you'd use the conditionals to print stuff out in debug mode so you can isolate the crash. No PSPLink necessary. It's tedious, but it works.