Printable View
OMG TMNT! No, it's not that bad, but do you know what a switch-case statement is? If not, look it up. That will GREATLY improve the style in this code.
Two other tips:
In one line if statements, you don't need brackets.
Also, since you're not returning anything important, change 'int menu' to 'void menu', and remove the 'return 0' at the end of the menu function.Code:if (!blah) doSomething();
Since when is coding STYLE not personal preference? I would have just put everything into arrays and use loops for loading sounds and images. I would have used switch-case for the "ed Attributes". And I would have indented better.
Lol...yea, i thought that was an paradox...Zitat:
Zitat von Moca
Yes, i know what a switch case is...i just haven't used it in this program yet. They are actually much better than using a bunch of else if's.
Here's an example of a switch case loop. Here's before:
And here's after:Code:if (PlayerStatus == 1) { PlayerOffsetX = 3; PlayerOffsetY = 2; PlayerWidth = 38; PlayerHeight = 55; }
if (PlayerStatus == 2) { PlayerOffsetX = 48; PlayerOffsetY = 2; PlayerWidth = 38; PlayerHeight = 55; }
if (PlayerStatus == 3) { PlayerOffsetX = 92; PlayerOffsetY = 2; PlayerWidth = 37; PlayerHeight = 55; }
It's not always shorter, but it's better coding style.Code:switch(PlayerStatus) {
case 1:
PlayerOffsetX = 3;
PlayerOffsetY = 2;
PlayerWidth = 38;
PlayerHeight = 55;
break;
case 2:
PlayerOffsetX = 48;
PlayerOffsetY = 2;
PlayerWidth = 38;
PlayerHeight = 55;
break;
case 3:
PlayerOffsetX = 92;
PlayerOffsetY = 2;
PlayerWidth = 37;
PlayerHeight = 55;
break;
default:
break;
}
That wasn't necessary; i already knew about case statements. However, i can't use digits more than 9 (multidigits)...? I get this error when i compile.
Code:switch(PlayerStatus) {
//Player Standing
case '1': PlayerOffsetX = 3; PlayerOffsetY = 2; PlayerWidth = 38; PlayerHeight = 55; break;
case '2': PlayerOffsetX = 48; PlayerOffsetY = 2; PlayerWidth = 38; PlayerHeight = 55; break;
case '3': PlayerOffsetX = 92; PlayerOffsetY = 2; PlayerWidth = 37; PlayerHeight = 55; break;
//Player Running
case '4': PlayerOffsetX = 133; PlayerOffsetY = 1; PlayerWidth = 48; PlayerHeight = 56; break;
case '5': PlayerOffsetX = 187; PlayerOffsetY = 1; PlayerWidth = 37; PlayerHeight = 56; break;
case '6': PlayerOffsetX = 224; PlayerOffsetY = 1; PlayerWidth = 47; PlayerHeight = 56; break;
//Player Kicking
case '7': PlayerOffsetX = 286; PlayerOffsetY = 1; PlayerWidth = 37; PlayerHeight = 56; break;
case '8': PlayerOffsetX = 335; PlayerOffsetY = 1; PlayerWidth = 37; PlayerHeight = 56; break;
case '9': if (PlayerFacing == LEFT) { PlayerPosX = PlayerPosX - 1; } PlayerOffsetX = 378; PlayerOffsetY = 1; PlayerWidth = 55; PlayerHeight = 56; break;
//Player Jumping
case '10': PlayerOffsetX = 4; PlayerOffsetY = 63; PlayerWidth = 30; PlayerHeight = 57; break;
//Player Hurt
case '11': PlayerOffsetX = 43; PlayerOffsetY = 67; PlayerWidth = 40; PlayerHeight = 54; break;
case '12': PlayerOffsetX = 85; PlayerOffsetY = 67; PlayerWidth = 41; PlayerHeight = 53; break;
case '13': PlayerOffsetX = 135; PlayerOffsetY = 70; PlayerWidth = 37; PlayerHeight = 51; break;
//Player Dead
case '14': PlayerOffsetX = 187; PlayerOffsetY = 72; PlayerWidth = 37; PlayerHeight = 49; break;
case '15': PlayerOffsetX = 233; PlayerOffsetY = 73; PlayerWidth = 37; PlayerHeight = 47; break;
case '16': PlayerOffsetX = 279; PlayerOffsetY = 75; PlayerWidth = 36; PlayerHeight = 45; break;
}
you need braces around the case if it executes more than one line of codeZitat:
Zitat von TMNT
also, this is entirely personal preference, but having that many comments, and the way you write them (being all creative ;)) *i think* gets in the way sometimes. again, just my 2 cents.
What do you mean?Zitat:
Zitat von Grimfate126
Also, how do i fix the "case > 9"/multidigital case problems.
Besides indents which is one of my biggest pet hates and assuming you are coding in C and not C++:Zitat:
Zitat von TMNT
> Lose the ASCII comment art. They are hard to maintain and can be easily replaced by something more simpler to the same effect. E.g
> Use // over /* */ style comments. The reason is because of this:Code://///////////////////////////////////////////////////////////
// GAME
/////////////////////////////////////////////////////////////
Then you realise you want to comment out lines 1 and 5 so you attempt to comment the whole block again:Code:some random code 1
/* some random code 2
some random code 3
some random code 4 */
some random code 5
Whoops, the compiler only sees lines 1-4 commented as one block, and ignores the second /*. Therefore compiling line 5 is attempted and fails because of a syntax error for */Code:/* some random code 1
/* some random code 2
some random code 3
some random code 4 */
some random code 5 */
> Still using magic number in a lot of places:
Code:print((480/3*0.5-32) + (SelectionPosition), 242, "Continue");
Use named constants or at least #definesCode:if (MenuStatus == 2)
{
Stop_Sound(motherland);
ShowCredits = 2;
}
if (MenuStatus == 3)
{
oslEndGfx();
oslQuit();
}
> When you create variables, always intitalise them ESPECIALLY pointers. A NULL pointer is easier to track down and recognise then an uninitiailised one.
Should be:Code:OSL_SOUND *click, *motherland, *music, *kick, *run, *jump;
> Aim for one line per logical line of code as it makes it much easier to read. I.E This:Code:OSL_SOUND *click = NULL, *motherland = NULL, *music = NULL, *kick = NULL, *run = NULL, *jump = NULL;
Should be:Code:int main()
{
menu(); return 0;
}
And this:Code:int main()
{
menu();
return 0;
}
Should be:Code:if (ShowCredits == 1) {
oslSetAlpha(OSL_FX_ALPHA,Alpha);
blit(credits, 0, 0);
if (FadeIn == 1) { Alpha++; }
else if (FadeIn == 0) { Alpha--; }
if (Alpha > 254) { wait(3000000); FadeIn = 0; }
else if (Alpha < 1) { Alpha = 0; ShowCredits = 0; }
}
> Don't do this:Code:if (ShowCredits == 1)
{
oslSetAlpha(OSL_FX_ALPHA,Alpha);
blit(credits, 0, 0);
if (FadeIn == 1)
{
Alpha++;
}
else if (FadeIn == 0)
{
Alpha--;
}
if (Alpha > 254)
{
wait(3000000);
FadeIn = 0;
}
else if (Alpha < 1)
{
Alpha = 0;
ShowCredits = 0;
}
}
If you are going to use a function from the library, then use the name they give it. The main reason for this is that if I am looking at a section of code on line 1000 odd and I see "print", I would think that it is a function you have written yourself and I am forced to look at what it does which is wasted time and effort and takes my focus away at the task at hand.Code:#define print oslPrintf_xy
#define Load_Sound oslLoadSoundFile
#define Stop_Sound oslStopSound
#define Load_Image oslLoadImageFile
#define Load_Font oslLoadFontFile
#define blit oslDrawImageXY
#define wait sceKernelDelayThread
If it was "oslPrintf_xy" then I know immediately that it is from Old School library and prints at X Y screen co-ords using printf style formating.
> In equality checks, place the constant on the left. I.E:
To:Code:if (PlayerStatus == 1)
This means that if you accidentally do:Code:if (1 == PlayerStatus)
The compiler with give an error saying that this is impossible where as:Code:if (1 = PlayerStatus)
The compiler will at best give a warning but still build fully.Code:if (PlayerStatus = 1)
> <Huge preference!> Prefix pointer variable names with a 'p'. It makes it easy to identify pointer variables lines away from where they are declared. E.g.
> <Huge preference!> One variable declaration per line. The reason is because this can happen:Code:int * pInt = NULL;
int ** ppInt = NULL;
int *** pppInt = NULL'
Ooops. Didn't you mean:Code:int * pIntA = NULL, pIntB = NULL, pIntC = NULL;
> Quit the game if it cannot be played:Code:int * pIntA = NULL;
int * pIntB = NULL;
int * pIntC = NULL;
Why doesn't the function end here straight away? Even though the image(s) are NULL, the rest of the function still runs.Code:if (!background || !credits || !opening || !Ed || !level1) { oslDebug("Error: Could not load one or more images"); }
> Aim for functions to be no more then a screen high in length. It makes them easier to read and maintain. Ideally, you shouldn't need to scroll at all to read a whole function.
That's it from a quick scan from me. More information can be found at the coding standards here:
http://www.research.att.com/~bs/JSF-AV-rules.pdf
And from a games company here:
http://blackcompanystudios.co.uk/cod...itle=Main_Page
I highly recommend skimming through them at least.
-= Double Post =-
No you don't. You only need braces if you declare variables in a case statement: IEZitat:
Zitat von Grimfate126
Won't compile:Code:case WRONG_CHOICE:
int blah = 0;
Something( blah );
break;
Will compile.Code:case WRONG_CHOICE:
{
int blah = 0;
Something( blah );
} break;
What yo are thinking about are if statements.
-= Double Post =-
Why are you using ''? That means a char, '12' is not a char don't you meanCode:switch(PlayerStatus) {
//Player Standing
case '1': PlayerOffsetX = 3; PlayerOffsetY = 2; PlayerWidth = 38; PlayerHeight = 55; break;
case '2': PlayerOffsetX = 48; PlayerOffsetY = 2; PlayerWidth = 38; PlayerHeight = 55; break;
case '3': PlayerOffsetX = 92; PlayerOffsetY = 2; PlayerWidth = 37; PlayerHeight = 55; break;
//Player Running
case '4': PlayerOffsetX = 133; PlayerOffsetY = 1; PlayerWidth = 48; PlayerHeight = 56; break;
case '5': PlayerOffsetX = 187; PlayerOffsetY = 1; PlayerWidth = 37; PlayerHeight = 56; break;
case '6': PlayerOffsetX = 224; PlayerOffsetY = 1; PlayerWidth = 47; PlayerHeight = 56; break;
//Player Kicking
case '7': PlayerOffsetX = 286; PlayerOffsetY = 1; PlayerWidth = 37; PlayerHeight = 56; break;
case '8': PlayerOffsetX = 335; PlayerOffsetY = 1; PlayerWidth = 37; PlayerHeight = 56; break;
case '9': if (PlayerFacing == LEFT) { PlayerPosX = PlayerPosX - 1; } PlayerOffsetX = 378; PlayerOffsetY = 1; PlayerWidth = 55; PlayerHeight = 56; break;
//Player Jumping
case '10': PlayerOffsetX = 4; PlayerOffsetY = 63; PlayerWidth = 30; PlayerHeight = 57; break;
//Player Hurt
case '11': PlayerOffsetX = 43; PlayerOffsetY = 67; PlayerWidth = 40; PlayerHeight = 54; break;
case '12': PlayerOffsetX = 85; PlayerOffsetY = 67; PlayerWidth = 41; PlayerHeight = 53; break;
case '13':{ PlayerOffsetX = 135; PlayerOffsetY = 70; PlayerWidth = 37; PlayerHeight = 51; break;
//Player Dead
case '14': PlayerOffsetX = 187; PlayerOffsetY = 72; PlayerWidth = 37; PlayerHeight = 49; break;
case '15': PlayerOffsetX = 233; PlayerOffsetY = 73; PlayerWidth = 37; PlayerHeight = 47; break;
case '16': PlayerOffsetX = 279; PlayerOffsetY = 75; PlayerWidth = 36; PlayerHeight = 45; break;
}
Code:switch(PlayerStatus) {
//Player Standing
case 1: PlayerOffsetX = 3; PlayerOffsetY = 2; PlayerWidth = 38; PlayerHeight = 55; break;
case 2: PlayerOffsetX = 48; PlayerOffsetY = 2; PlayerWidth = 38; PlayerHeight = 55; break;
case 3: PlayerOffsetX = 92; PlayerOffsetY = 2; PlayerWidth = 37; PlayerHeight = 55; break;
//Player Running
case 4: PlayerOffsetX = 133; PlayerOffsetY = 1; PlayerWidth = 48; PlayerHeight = 56; break;
case 5: PlayerOffsetX = 187; PlayerOffsetY = 1; PlayerWidth = 37; PlayerHeight = 56; break;
case 6: PlayerOffsetX = 224; PlayerOffsetY = 1; PlayerWidth = 47; PlayerHeight = 56; break;
//Player Kicking
case 7: PlayerOffsetX = 286; PlayerOffsetY = 1; PlayerWidth = 37; PlayerHeight = 56; break;
case 8: PlayerOffsetX = 335; PlayerOffsetY = 1; PlayerWidth = 37; PlayerHeight = 56; break;
case 9: if (PlayerFacing == LEFT) { PlayerPosX = PlayerPosX - 1; } PlayerOffsetX = 378; PlayerOffsetY = 1; PlayerWidth = 55; PlayerHeight = 56; break;
//Player Jumping
case 10: PlayerOffsetX = 4; PlayerOffsetY = 63; PlayerWidth = 30; PlayerHeight = 57; break;
//Player Hurt
case 11: PlayerOffsetX = 43; PlayerOffsetY = 67; PlayerWidth = 40; PlayerHeight = 54; break;
case 12: PlayerOffsetX = 85; PlayerOffsetY = 67; PlayerWidth = 41; PlayerHeight = 53; break;
case 13:{ PlayerOffsetX = 135; PlayerOffsetY = 70; PlayerWidth = 37; PlayerHeight = 51; break;
//Player Dead
case 14: PlayerOffsetX = 187; PlayerOffsetY = 72; PlayerWidth = 37; PlayerHeight = 49; break;
case 15: PlayerOffsetX = 233; PlayerOffsetY = 73; PlayerWidth = 37; PlayerHeight = 47; break;
case 16: PlayerOffsetX = 279; PlayerOffsetY = 75; PlayerWidth = 36; PlayerHeight = 45; break;
}
damit. the pwnage never stops...Zitat:
Zitat von yaustar
OMFG! Grimfate got PWNED by Yaustar again! Lol...
Thanks Yaustar; i had not thought about those. Genius. I am rewriting my code based on those suggestions, and i will post my finished code when i am done.
It's probably more beneficial to everyone involved if you think of it as friendly and cooperative advice, rather than "pwnage."Zitat:
Zitat von Grimfate126
Just to reemphasise the links I made since they are lost in the post:
That's it from a quick scan from me. More information can be found at the coding standards here:
http://www.research.att.com/~bs/JSF-AV-rules.pdf
And from a games company here:
http://blackcompanystudios.co.uk/cod...itle=Main_Page
These are actual coding standards used by companies in the real world.
Actually, pwnage at qj actually is Grimfate and my way of saying "thanks for the constructive criticism". Remember, this is a COMMUNITY. We all love Yaustar for his geniusness.....and sexyness (i didn't just say that).Zitat:
Zitat von soccerPMN
Thanks for those books Yaustar; pretty helpful.
Edit:
Oooops. Yea Yaustar, you are right about the cases. I forgot i wasn't dealing with letters (i had used switch cases in my other program with letters).
Just trying to keep my edits up with yours.
Grimfate - be glad you have his answer. A lot of other higher-ups, not saying they are arrogant, but they just don't bother to deal with petty problems :( (be it cause of work, etc.). I admire you greatly yaustar :o
yaustar - I like the pointer naming style. Pretty much every class I've been using (LTE) is a pointer. I've lately been having to make sure, when using the engine, to check the variable's definition whether it is in fact a pointer :( That should save me a headache ;)
By the way, are statically initialized variables popped off the stack when out of scope?
Do you mean these?Zitat:
Zitat von SG57
So these are created the first time the function is called and exist throughout the life time of the whole program but can only be accessed in the scope of the function.Code:int function()
{
static int blah = 0;
}
I honestly don't know where in memory are these created (stack, heap, some area of the executable, etc). I have a feeling it is compiler dependent but not 100% sure. I may have to read the C++ standard sometime :/
Ah ok - does the compiler through an error or at least a warning saying you are accessing blah out of function()'s scope? Or does it say it's undefined? I ask because statically initialized variables may cause naming conflicts should I need to use them and I'd rather not run into that problem when debugging :(
holy hell. i was gone for like 15 mins, and there were like 10 new posts. btw, i was kidding about the pwange part. its what i always say when yaustar corrects me ;) (yaustar knows, i think. lol)
sorry for all misunderstandings. lol.
[sarcasm]don't lie to us we know you were serious[/sarcasm]
If you try to access it from a different scope, it will give a compiler error.Zitat:
Zitat von SG57
Thanks for clearing that up yaustar - was nagging at me to ask it all day :-( Yet another possible headache prevented - I appreciate it greatly :o
Did you hear the news? Are you surprised? Do i want me to do it? Why am i asking so many questions?Zitat:
Zitat von SG57
Quite a few pages ago I mentioned some problems with SG57's game; I have tried compiling it, and even sending to multiple people for compiling but I keep getting nada. For some reason, even when they have OSlib installed, it doesn't compile and there are errors even though I have double and triple checked it, Do you guys, with your "genius" brains know anything that i can try doing?
I am wondering if I got a corrupt of version of SG57's source code... If I did, I could try downloading it again and fixing it up the same as the newer one that I have made...
Can you post the error messages (again?)?
They weren't specific error messages but let me see what I can do. I'm not at that computer at the moment so I don't know for sure, but from what I remember, it was just wierd errors about oslibdraw and other phrases that should work, with oslib installed of course.
I will reply back in the next couple of hours. Work>coding
spike - You should get the OSlib documentation, that way any undefined references/implicit declarations you receive you can check on your own for faster debugging. I made wrappers around the oslib draw functions cause oslib doesnt have a built in ellipse drawing function so I was going to write my own, but i found loading an image better cause i can rotate it, scale it and make the actual image better (i drew a face on it :P)
Heres an (outdated?) online doc.
http://oslib.playeradvance.org/doku....=documentation
Irrelevant - Approaching 8,000 posts ^^
This is also irrelevant, but I remember when the C Help Thread had 1/4 of the posts of the Lua Help Thread. Now, they're approaching the same numbers. This is because of one of two things.
1. Lua coders got smart enough to not need to ask questions.
2. Lua coders are converting to C.
Either way, it's good for the homebrew community.
[email protected] ~/psptoolchain
$ ./toolchain.sh
ERROR: Set $PSPDEV before continuing.
../depends/check-pspdev.sh: Failed.
..., I changed the .bat to what is supposed to be and I get this. ?_?
Regarding your earlier post SG57, I have looked through a few docs, including the one that came with the files that I had downloaded a while back. I still don't get why there is a problem with it.Zitat:
Zitat von SG57
... Do you think that it could just be my computer? Would it be better if I were to install an emulated version of Linux and then just compile using that?
If you can compile period, your computer is fine.
Just post the error youll get a fix i'm almost positive ;)
Is there such a thing as being smart enough to not ask questions? and why is it that much better that there "converting"? The small games that are made with lua are usually quite fun if done right (like any game in general) and they are faster to make, meaning more games are made.Zitat:
Zitat von Judas