Lua Skateboarding - Menu Help :(

[AndyMosh]

Hey all, i am having some problems with my menu for my game which i will release when finished...

I have some images which will change when people press down or up on the menu,
My problem is that it loads the menu screen but when i press down or x it just stays on the same image, here is my code:

red = Color.new(255,0,0)
green = Color.new(0,255,0)
blue = Color.new(0,0,255)
yellow = Color.new(255,255,0)
purple = Color.new(255,0,255)
play = Image.load("mselectplay.png")
credits = Image.load("mselectcred.png")
score = Image.load("mselectscore.png")
function delay(seconds)
	time=seconds*60
	for i=1, time do
		screen.waitVblankStart()
	end
end
-- select
while true do
screen:blit(0,0,play)
screen.flip()
end
pad = Controls.read()
if pad:cross() then
dofile("game.lua")
end 
if pad:down() then
screen:blit(0,0,credits)
screen.flip()
end
if pad:cross() then
dofile("credits.lua")
end
if pad:down() then
screen:blit(0,0,score)
screen.flip()
end
if pad:cross() then
dofile("hiscore.lua")
end

As you can see above is where the controls are, i think the problem might be ending the ifs too soon or something like that or it might be this bit of code:

	for i=1, time do
		screen.waitVblankStart()
	end
end
-- select
while true do
screen:blit(0,0,play)
screen.flip()
end
pad = Controls.read()

Which might be ending the loop too soon therefor not reading the controls?

Please help i really want this game to work and then i might make a series

[psphacker12.]

hmm.....
try this.. instead..

red = Color.new(255,0,0)
green = Color.new(0,255,0)
blue = Color.new(0,0,255)
yellow = Color.new(255,255,0)
purple = Color.new(255,0,255)
play = Image.load("mselectplay.png")
credits = Image.load("mselectcred.png")
score = Image.load("mselectscore.png")
  function delay(seconds)
  time=seconds*60
  for i=1, time do
  screen.waitVblankStart()
  end
end
-- select
while true do
status = 0
screen:blit(0,0,play)
screen.flip()
end
pad = Controls.read()
if pad:cross() and status == 0 then
status = ingame
dofile("game.lua")
end 
if pad:down() and status == 0 then
status = 1
screen:blit(0,0,credits)
screen.flip()
end
if pad:cross()  and status == 1 then
dofile("credits.lua")
end
if pad:down() and status == 1 then
status = 2
screen:blit(0,0,score)
screen.flip()
end
if pad:cross() and status == 2 then
dofile("hiscore.lua")
end
if pad:down() and status == 2 then
status = 0
end
end

[Bronx]

Don't blit pictures right in a if statement, use a finit state... like for example:

 blit_credits = 0

if pad:cross() then
blit_credits = 1
end

if blit_credits == 1 then
screen:blit(0,0, "credits")
end

And you shouldn't have the screen.flip() after them either.

And this:

while true do
screen:blit(0,0,play)
screen.flip()
end
pad = Controls.read()

Should be:

while true do

//do all if statements in-game stuff here
pad = Controls.read()
screen:blit(0,0,play)
screen.flip()
screen.waitVblankStart()
end

[psphacker12.]

Originally Posted by Bronx

Don't blit pictures right in a if statement, use a finit state... like for example:

 blit_credits = 0

if pad:cross() then
blit_credits = 1
end

if blit_credits == 1 then
screen:blit(0,0, "credits")
end

And you shouldn't have the screen.flip() after them either.

And this:

while true do
screen:blit(0,0,play)
screen.flip()
end
pad = Controls.read()

Should be:

while true do

//do all if statements in-game stuff here
pad = Controls.read()
screen:blit(0,0,play)
screen.flip()
screen.waitVblankStart()
end

lol bronx in lua its not // its --

[Bronx]

oops.... lol, haven't programmed in la for awhile , just natural now

[AndyMosh]

Bronx how would i make it that when it loads mselectplay if they press down it will blit another image?

[psphacker12.]

Originally Posted by AndyMosh

Bronx how would i make it that when it loads mselectplay if they press down it will blit another image?

Just use this and it should work..

Spoiler for Code:

red = Color.new(255,0,0)
green = Color.new(0,255,0)
blue = Color.new(0,0,255)
yellow = Color.new(255,255,0)
purple = Color.new(255,0,255)
play = Image.load("mselectplay.png")
credits = Image.load("mselectcred.png")
score = Image.load("mselectscore.png")
  function delay(seconds)
  time=seconds*60
  for i=1, time do
  screen.waitVblankStart()
  end
end
-- select
while true do
status = 0
screen:blit(0,0,play)
pad = Controls.read()
if pad:cross() and status == 0 then
status = ingame
dofile("game.lua")
end 
if pad:down() and status == 0 then
status = 1
screen:blit(0,0,credits)
screen.flip()
end
if pad:cross()  and status == 1 then
dofile("credits.lua")
end
if pad:down() and status == 1 then
status = 2
screen:blit(0,0,score)
screen.flip()
end
if pad:cross() and status == 2 then
dofile("hiscore.lua")
end
if pad:down() and status == 2 then
status = 0
end

[AndyMosh]

I've tried it and it says (eof) expected near 'end' you know that error?

[psphacker12.]

Originally Posted by AndyMosh

I've tried it and it says (eof) expected near 'end' you know that error?

Try this.

red = Color.new(255,0,0)
green = Color.new(0,255,0)
blue = Color.new(0,0,255)
yellow = Color.new(255,255,0)
purple = Color.new(255,0,255)
play = Image.load("mselectplay.png")
credits = Image.load("mselectcred.png")
score = Image.load("mselectscore.png")
  function delay(seconds)
  time=seconds*60
  for i=1, time do
  screen.waitVblankStart()
  end
end
-- select
while true do
status = 0
screen:blit(0,0,play)
pad = Controls.read()
if pad:cross() and status == 0 then
status = ingame
dofile("game.lua")
end 
if pad:down() and status == 0 then
status = 1
screen:blit(0,0,credits)
screen.flip()
end
if pad:cross()  and status == 1 then
dofile("credits.lua")
end
if pad:down() and status == 1 then
status = 2
screen:blit(0,0,score)
screen.flip()
end
if pad:cross() and status == 2 then
dofile("hiscore.lua")
end
if pad:down() and status == 2 then
status = 0
end

there was an unneeded end statement near screen:blit

[Bronx]

what line? you probably forgot an 'end'

and for your other question, I don't see mselectplay in your code, but ti would be someting like this:

 if mselectplay and pad:down() then
--blit w/e
end

acourse I did say not blit in a if statement, but thats the idea, you should be able t merge it with a finite state machine

[AndyMosh]

psphacker12 after i used that it said 'end' expected near :16: (eof)

[psphacker12.]

Originally Posted by AndyMosh

psphacker12 after i used that it said 'end' expected near :16: (eof)

then try this instead:

Spoiler for *:

red = Color.new(255,0,0)
green = Color.new(0,255,0)
blue = Color.new(0,0,255)
yellow = Color.new(255,255,0)
purple = Color.new(255,0,255)
play = Image.load("mselectplay.png")
credits = Image.load("mselectcred.png")
score = Image.load("mselectscore.png")
  function delay(seconds)
  time=seconds*60
  for i=1, time do
  screen.waitVblankStart()
  end
end
-- select
while true do
status = 0
screen:blit(0,0,play)
pad = Controls.read()
if pad:cross() and status == 0 then
status = ingame
dofile("game.lua")
end 
if pad:down() and status == 0 then
status = 1
screen:blit(0,0,credits)
screen.flip()
end
if pad:cross()  and status == 1 then
dofile("credits.lua")
end
if pad:down() and status == 1 then
status = 2
screen:blit(0,0,score)
screen.flip()
end
if pad:cross() and status == 2 then
dofile("hiscore.lua")
end
if pad:down() and status == 2 then
status = 0
end
end

[AndyMosh]

Originally Posted by Bronx

Don't blit pictures right in a if statement, use a finit state... like for example:

 blit_credits = 0

if pad:cross() then
blit_credits = 1
end

if blit_credits == 1 then
screen:blit(0,0, "credits")
end

And you shouldn't have the screen.flip() after them either.

And this:

while true do
screen:blit(0,0,play)
screen.flip()
end
pad = Controls.read()

Should be:

while true do

//do all if statements in-game stuff here
pad = Controls.read()
screen:blit(0,0,play)
screen.flip()
screen.waitVblankStart()
end

I don't get the blit_credits = 0 part is there a tu on this anywhere?

[psphacker12.]

Originally Posted by AndyMosh

I don't get the blit_credits = 0 part is there a tu on this anywhere?

It is just a simple nil variable.
____
(0_o)
-\_/-
--|--
-/-\-

[AndyMosh]

psphacker12 it doesn't matter i will work it out myself

[Bronx]

If you go over to forums.evilmana.com they are mant threads similiar to this one. I'm sure you will find your answer there

[AndyMosh]

Edit: Don't want my code sharing, and i figured it out i was ending too soon

[LMelior]

When you help somebody, please explain what is wrong and what could be done better, don't just give them code to try. For instance, you don't need that delay function. The command screen.waitVblankStart accepts input, so this is the same as yours:

screen.waitVblankStart(seconds*60)

You already know that you ended the while loop before you read the controls, so I'll just give you some general help. When you're writing code, think about exactly what the code will make the interpreter do. Take the latest code that psphacker posted (I don't know whose code is whose):

while true do
status = 0

This sets the status to zero at the beginning of each loop...are you sure you want to do that?

screen:blit(0,0,play)
pad = Controls.read()

You read the controls once each loop, which is good. That's all you should need. But...

if pad:cross() and status == 0 then
status = ingame
dofile("game.lua")
end 
if pad:down() and status == 0 then
status = 1
screen:blit(0,0,credits)
screen.flip()
end

If you were pressing down when the controls were read, this part sets the status to 1...

if pad:cross()  and status == 1 then
dofile("credits.lua")
end
if pad:down() and status == 1 then
status = 2
screen:blit(0,0,score)
screen.flip()
end

Which triggers this "if" statement, setting the status to 2...

if pad:cross() and status == 2 then
dofile("hiscore.lua")
end
if pad:down() and status == 2 then
status = 0
end

Which triggers this "if" statement, setting the status back to 0. So no matter what you do, this code makes doubly sure that you'll never get out of status == 0.

I think a common problem among new coders is that they don't realize how fast the code will run. You don't have a screen.waitVblankStart, which would limit your execution speed to at most 60 loops per second, so this code will go even faster. Stuff like this would only work if you read the controls after each change and you actually had time to react to them, which just isn't realistic.

[AndyMosh]

Hey dude, thanks i figured it out in the end, Freshmilk is helping me through lua aswell, if i need help he usually knows the answer, so i have done the loading screen menu and credits, now for the game, and i want to know what type of simple skateboarding game would you like? not too complicated though, my first game will hopeflly make a series with the ability to choose decks?

[Freshmilk]

i'm touched

lol, im going now, thanks for mentioning me andy.

[AndyMosh]

No problem dude, your a real good friend when helping people