What is a simpler, more efficient way of writing this...

[JaSo PsP]

Im currently making a lottery game. I have some if statements that look like they can be smaller than they are: (this is in actionscript, flash 8)

on (press) {
	success = 0;
	if (in1 == null || in2 == null || in3 == null || in4 == null || in5 == null || in6 == null || in1 == "" || in2 == "" || in3 == "" || in4 == "" || in5 == "" || in6 == "") {
		ready = 0;
		messag = "Enter ALL numbers";
	} else if (in2>49 || in3>49 || in4>49 || in5>49 || in6>49) {
		ready = 0;
		messag = "Numbers must range from 0-49";
	} else if (in1 == in2 || in1 == in3 || in1 == in4 || in1 == in5 || in1 == in6 || in2 == in3 || in2 == in4 || in2 == in5 || in2 == in6 || in3 == in4 || in3 == in5 || in3 == in6 || in4 == in5 || in4 == in6 || in5 == in6) {
		ready = 0;
		messag = "Numbers cannot be the same";
	} else {
		ready = 1;
	}
	if (ready == 1) {
		out1 = Math.round(Math.random()*49);
		out2 = Math.round(Math.random()*49);
		out3 = Math.round(Math.random()*49);
		out4 = Math.round(Math.random()*49);
		out5 = Math.round(Math.random()*49);
		out6 = Math.round(Math.random()*49);
		if (out1 == out2 || out1 == out3 || out1 == out4 || out1 == out5 || out1 == out6) {
			out1 = Math.round(Math.random()*49);
		}
		if (out2 == out3 || out2 == out4 || out2 == out5 || out2 == out6) {
			out2 = Math.round(Math.random()*49);
		}
		if (out3 == out4 || out3 == out5 || out3 == out6) {
			out3 = Math.round(Math.random()*49);
		}
		if (out4 == out5 || out4 == out6) {
			out4 = Math.round(Math.random()*49);
		}
		if (out5 == out6) {
			out5 = Math.round(Math.random()*49);
		}
		if (out1 == 0) {
			out1 = Math.round(Math.random()*49);
		}
		if (out2 == 0) {
			out2 = Math.round(Math.random()*49);
		}
		if (out3 == 0) {
			out3 = Math.round(Math.random()*49);
		}
		if (out4 == 0) {
			out4 = Math.round(Math.random()*49);
		}
		if (out5 == 0) {
			out5 = Math.round(Math.random()*49);
		}
		if (out6 == 0) {
			out6 = Math.round(Math.random()*49);
		}
		if (in1 == out1 || in1 == out2 || in1 == out3 || in1 == out4 || in1 == out5 || in1 == out6) {
			success++;
		}
		if (in2 == out1 || in2 == out2 || in2 == out3 || in2 == out4 || in2 == out5 || in2 == out6) {
			success++;
		}
		if (in3 == out1 || in3 == out2 || in3 == out3 || in3 == out4 || in3 == out5 || in3 == out6) {
			success++;
		}
		if (in4 == out1 || in4 == out2 || in4 == out3 || in4 == out4 || in4 == out5 || in4 == out6) {
			success++;
		}
		if (in5 == out1 || in5 == out2 || in5 == out3 || in5 == out4 || in5 == out5 || in5 == out6) {
			success++;
		}
		if (in6 == out1 || in6 == out2 || in6 == out3 || in6 == out4 || in6 == out5 || in6 == out6) {
			success++;
		}
		messag = "You matched "+success+" numbers";
		if (success == 1) {
			messag = "You matched "+success+" number";
		}
			
	}
}

There must be a way to make it more efficient, maybe using arrays?

(highlight the if statements' conditions that go off the screen to reveal their mammouth lengh)
-= Double Post =-
Come On!

[yaustar]

Do you have arrays in actionscript?

[SG57]

Googles first link:

http://www.adobe.com/support/flash/a...ionary059.html

[JaSo PsP]

Originally Posted by SG57

Googles first link:

http://www.adobe.com/support/flash/a...ionary059.html

Hmm, i still dont know how to write about all the elements in an array at once.

[Bytrix]

You might be able to reduce it by a few lines but it won't be more efficient. Those conditionals will take just as long to run if you were using arrays in some way. I can't see any clear way to cut them down either.

[MiG]

Use a for loop in places, and then make it easier to read with a switch statement..

Switch statement should be a more elegant solution...

Also, dunno if this is true with actionscript, but:

if you have an IF statement, with one like of code for the result, you can leave the brackets out..

So just have...

if (blah == true)
//Result goes here.

[JaSo PsP]

Originally Posted by MiG

Use a for loop in places, and then make it easier to read with a switch statement..

Switch statement should be a more elegant solution...

Also, dunno if this is true with actionscript, but:

if you have an IF statement, with one like of code for the result, you can leave the brackets out..

So just have...

if (blah == true)
//Result goes here.

That last part isnt phesable

[matriculated]

// number of picks
var picks = 6;
// highest number to pick
var max = 49;
// lotto numbers
var out:Array = new Array();
//
// numbers that you can choose from
var num:Array = new Array();
//
var x, y, success:Number;
//
//initialize the array that holds the numbers you can choose
for (x=0; x<max; x++) {
	num[x] = x+1;
}
//
// make the input fields and init to 0
for (x=0; x<picks; x++) {
	_root.createTextField("input"+x, x+10, 20, x*20+20, 100, 20);
	// dirty evals here because my actionscript is rusty
	eval("input"+x).border = 1;
	eval("input"+x).backgroundColor = 0x000000;
	eval("input"+x).text = "0";
	eval("input"+x).restrict = "0-9";
	eval("input"+x).type = "input";
}
//
//choose a non-repeating random number from 1-49 five times for the lotto
for (x=0; x<picks; x++) {
	// choose a number from the num array
	out[x] = num[Math.floor(Math.random()*num.length)];
	//delete the array element that was choosen so we don't choose it again
	num.splice(x, 1);
}
trace("Winning numbers are: "+out.join(", "));
//
// make a button
_root.createEmptyMovieClip("theButton_mc", 1000);
theButton_mc._x = theButton_mc._y=0;
with (theButton_mc) {
	beginFill(0x555555, 100);
	moveTo(140, 20);
	lineTo(200, 20);
	lineTo(200, 40);
	lineTo(140, 40);
	endFill();
}
// attach actionscript to check winning numbers to the button
theButton_mc.onRelease = function() {
	// make an array to recorde the matching numbers
	var match:Array = new Array();
	var err:Boolean;
	// check for dupes
	dupes = false;
	// probably a better way to do this but...
	for (x=0; x<picks; x++) {
		for (y=0; y<picks; y++) {
			if (int(eval("input"+x).text)<1 or int(eval("input"+x).text)>max or (x != y and (int(eval("input"+x).text) == int(eval("input"+y).text)))) {
				dupes = dupes or true;
			}
		}
	}
	if (dupes) {
		trace("duplicate numbers entered or numbers are too high. try again.");
	} else {
		// check for matches
		success = 0;
		for (x=0; x<picks; x++) {
			for (y=0; y<out.length; y++) {
				if (int(eval("input"+x).text) == out[y]) {
					match[success] = out[y];
					success++;
				}
			}
		}
		trace(success+" numbers matched.");
		if (success>0) {
			trace("matching numbers are: "+match.join(", "));
		}
	}
};

just cut and paste into an empty flash document

[JaSo PsP]

Originally Posted by matriculated

// number of picks
var picks = 6;
// highest number to pick
var max = 49;
// lotto numbers
var out:Array = new Array();
//
// numbers that you can choose from
var num:Array = new Array();
//
var x, y, success:Number;
//
//initialize the array that holds the numbers you can choose
for (x=0; x<max; x++) {
	num[x] = x+1;
}
//
// make the input fields and init to 0
for (x=0; x<picks; x++) {
	_root.createTextField("input"+x, x+10, 20, x*20+20, 100, 20);
	// dirty evals here because my actionscript is rusty
	eval("input"+x).border = 1;
	eval("input"+x).backgroundColor = 0x000000;
	eval("input"+x).text = "0";
	eval("input"+x).restrict = "0-9";
	eval("input"+x).type = "input";
}
//
//choose a non-repeating random number from 1-49 five times for the lotto
for (x=0; x<picks; x++) {
	// choose a number from the num array
	out[x] = num[Math.floor(Math.random()*num.length)];
	//delete the array element that was choosen so we don't choose it again
	num.splice(x, 1);
}
trace("Winning numbers are: "+out.join(", "));
//
// make a button
_root.createEmptyMovieClip("theButton_mc", 1000);
theButton_mc._x = theButton_mc._y=0;
with (theButton_mc) {
	beginFill(0x555555, 100);
	moveTo(140, 20);
	lineTo(200, 20);
	lineTo(200, 40);
	lineTo(140, 40);
	endFill();
}
// attach actionscript to check winning numbers to the button
theButton_mc.onRelease = function() {
	// make an array to recorde the matching numbers
	var match:Array = new Array();
	var err:Boolean;
	// check for dupes
	dupes = false;
	// probably a better way to do this but...
	for (x=0; x<picks; x++) {
		for (y=0; y<picks; y++) {
			if (int(eval("input"+x).text)<1 or int(eval("input"+x).text)>max or (x != y and (int(eval("input"+x).text) == int(eval("input"+y).text)))) {
				dupes = dupes or true;
			}
		}
	}
	if (dupes) {
		trace("duplicate numbers entered or numbers are too high. try again.");
	} else {
		// check for matches
		success = 0;
		for (x=0; x<picks; x++) {
			for (y=0; y<out.length; y++) {
				if (int(eval("input"+x).text) == out[y]) {
					match[success] = out[y];
					success++;
				}
			}
		}
		trace(success+" numbers matched.");
		if (success>0) {
			trace("matching numbers are: "+match.join(", "));
		}
	}
};

just cut and paste into an empty flash document

That sort of defeats the point of it being MY game?

[matriculated]

Originally Posted by JaSo PsP

That sort of defeats the point of it being MY game?

I was really bored at work.

[JaSo PsP]

Originally Posted by matriculated

I was really bored at work.

INTRIGUING

PS: The guy in the link IS NOT me